Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add jaw camera #1856

Merged
merged 3 commits into from
Mar 15, 2024
Merged

add jaw camera #1856

merged 3 commits into from
Mar 15, 2024

Conversation

jimmytyyang
Copy link
Contributor

Motivation and Context

Add additional jaw camera into spot (intel realsense camera)

How Has This Been Tested

Using `interactive_play.py` to see the images

Types of changes

  • [Development] A pull request that add new features to the habitat-lab task and environment codebase. Development Pull Requests must be small (less that 500 lines of code change), have unit testing, very extensive documentation and examples. These are typically new tasks, environments, sensors, etc... The review process for these Pull Request is longer because these changes will be maintained by our core team of developers, so make sure your changes are easy to understand!

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation if required.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes if required.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 12, 2024
@zephirefaith zephirefaith mentioned this pull request Mar 14, 2024
Open
zephirefaith
zephirefaith approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@zephirefaith zephirefaith left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me, @jimmytyyang @tusharsangam
I added a small change aligning RGB pose with Depth pose. Also created these point-clouds using changed configuration, confirming this works for me. Please take a look and make sure this change does not break things on your end. I would be super happy to get this merged.

@jimmytyyang
Copy link
Contributor Author

thank you so much @zephirefaith for the review! let's get it merged!

@jimmytyyang jimmytyyang merged commit 45ff10c into main Mar 15, 2024
4 checks passed
@zephirefaith zephirefaith deleted the add_spot_camera branch March 15, 2024 15:11
dannymcy pushed a commit to dannymcy/habitat-lab that referenced this pull request Jul 8, 2024
@jimmytyyang @zephirefaith
add jaw camera (facebookresearch#1856)
edfdce8 
* add jaw camera

* match RGB with Depth specs

* pre-commit

---------

Co-authored-by: Jimmy Yang <jimmytyyang@meta.com>
Co-authored-by: Priyam Parashar <priyam8parashar@gmail.com>
HHYHRHY pushed a commit to SgtVincent/habitat-lab that referenced this pull request Aug 31, 2024
@jimmytyyang @zephirefaith
add jaw camera (facebookresearch#1856)
b8949a6 
* add jaw camera

* match RGB with Depth specs

* pre-commit

---------

Co-authored-by: Jimmy Yang <jimmytyyang@meta.com>
Co-authored-by: Priyam Parashar <priyam8parashar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zephirefaith zephirefaith zephirefaith approved these changes

@aclegg3 aclegg3 Awaiting requested review from aclegg3

@tusharsangam tusharsangam Awaiting requested review from tusharsangam

@SergioArnaud SergioArnaud Awaiting requested review from SergioArnaud

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimmytyyang @zephirefaith @facebook-github-bot