-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fairmotion Save/Load Metadata via JSON #1557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Do not delete this pull request or issue due to inactivity.
label
Nov 2, 2021
Skylion007
reviewed
Nov 3, 2021
Skylion007
reviewed
Nov 3, 2021
Skylion007
reviewed
Nov 3, 2021
Skylion007
reviewed
Nov 4, 2021
Skylion007
reviewed
Nov 5, 2021
Skylion007
reviewed
Nov 6, 2021
Skylion007
reviewed
Nov 6, 2021
Skylion007
reviewed
Nov 6, 2021
aclegg3
reviewed
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things to clean up and then should be ready. Functionality is fine.
Skylion007
reviewed
Nov 8, 2021
aclegg3
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR give FairmotionInterface users the ability to save and load their MoCap Character data to and from JSON metadata files. It also allows for rapid testing by simplifying data setting.
Features
P
andL
, respectively.SHIFT+P
. This is useful for saving change made by the character mouse positioning.CTRL+P
.R
to Reconfigure the scene and character, and pressF
to Load character data from the default JSON file.Example Metadata:
Example Metadata in JSON file:
How Has This Been Tested
Link to list of test cases passed
Types of changes
Checklist