Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YCB v1.2 #1772

Merged
merged 8 commits into from
Jun 10, 2022
Merged

YCB v1.2 #1772

merged 8 commits into from
Jun 10, 2022

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented Jun 1, 2022

Motivation and Context

Updates downloader default for YCB dataset to v1.2.

Also adds YCB object use and quick-start details to the DATASETS.md doc page.

Change-log:

  • removed "heavy" chef can object
  • improved organization:
    • moved object json files into configs directory
    • moved render assets into meshes directory
    • moved collision assets into collision_meshes directory
  • converted render assets to .glb and removed other formats
  • basis compressed textures in .glb files (originals still included as textured.glb.orig for editing in modeling software)
  • render meshes have been simplified for better render efficiency
  • texture size restored to higher resolution for better visuals

How Has This Been Tested

local testing

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jun 1, 2022
Copy link
Contributor

@dhruvbatra dhruvbatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instructions work for me. Visuals look higher-res than what I recall.

DATASETS.md Outdated Show resolved Hide resolved
aclegg3 and others added 2 commits June 8, 2022 12:24
Co-authored-by: dhruvbatra <dhruvbatra@users.noreply.github.com>
@aclegg3
Copy link
Contributor Author

aclegg3 commented Jun 9, 2022

We'll need to update the rearrange episodes to route additional_object_paths to data/objects/ycb/configs/ before tests will pass.

@aclegg3 aclegg3 merged commit ea8c778 into main Jun 10, 2022
@aclegg3 aclegg3 deleted the ycb-1.2 branch June 10, 2022 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants