Allow GLX to still be used if EGL doesn't work for whatever reason #1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have one for EGL, one for GLX, and one for external Magnum, and `git add -i` takes ages if those aren't ignored.
facebook-github-bot
added
the
CLA Signed
Skylion007
approved these changes
Sep 29, 2022
aclegg3
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
PR #1861 switched from GLX/EGL to unconditionally using EGL on Linux-y platforms. Which is a good thing to have in general, but there might still be cases where EGL might be broken, and for these it should be possible to switch back to something that works.
That has to be done manually by turning
MAGNUM_TARGET_EGLtoOFFindependencies.cmake, and this PR makes necessary buildsystem fixes to make the code compile again. The default EGL workflow is not affected by these changes in any way.Also contains a vaguely-related update for
.gitignore.How Has This Been Tested
Locally by setting the CMake option, running
ninjaand executing a few tests.