Better colors for "info" and "success" notes in the documentation and website #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning note was good enough already, but apparently those two were never used so far so they still had the dark theme colors. Also updated the m.css submodule to latest, because why not.
facebook-github-bot
added
the
CLA Signed
Skylion007
approved these changes
Oct 6, 2022
13 tasks
aclegg3
pushed a commit
that referenced
this pull request
Oct 6, 2022
The warning note was good enough already, but apparently those two were never used so far so they still had the dark theme colors. Also updated m.css to latest, and some other Doxyfile additions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Sorry for opening too many PRs lately :D I was in the process of writing high-level docs for the batch renderer in #1874, submitted #1889 for doc updates already, but then wanted to put some note blocks into the doc copy, realized they look kinda awful, and had to fix those too. Before:
After:
The "warning" note was good enough already, but apparently those two were never used so far so they still had the dark theme colors. I didn't spend time updating the remaining color styles for "primary" and "danger" as I don't need them at the moment, and this was enough of a detour already 😅 Same for #1812, originally I wanted to merge those changes with mine, but the font and spacing changes felt like a lot more time investment would be needed to get things look consistent again, so I didn't either. The two PRs don't conflict with each other, at least.
Also updated the m.css submodule to latest, because why not, and added a note into the documentation README about updating CSS colors. Reverting a change from #1889 that added a few new Doxygen aliases, as those were present in
Doxyfile-mcssalready; added a new alias for relative references that look shorter in the output, and added a predefinedDOXYGEN_GENERATING_OUTPUTmacro for hiding internal and nasty-looking code from Doxygen.Once merged, I'll transfer the CSS changes to the lab and website repos.
How Has This Been Tested
See screenshots above.