Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--[Habitat3.0] Removal of out-of-date/deprecated flags for IBL #2203

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

jturner65
Copy link
Contributor

@jturner65 jturner65 commented Sep 13, 2023

Motivation and Context

IBL is now enabled and balanced against direct lighting in the PBR shader by settings in xxx.pbr_config.json files and programmatically via PbrShaderAttributes configurations.

These flags have been ignored since the IBL rework was merged here but this PR removes them.

NOTE : This is a breaking change, in that any code that is setting the flag will now break. Any code doing this can be removed without issue, since whatever the flag is set to has been ignored since the PBR/IBL rework.

How Has This Been Tested

All existing c++ and python tests pass.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

-IBL is now controlled by settings in xxx.pbr_config.json files and programmatically via PbrShaderAttributes configurations.
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Sep 13, 2023
Copy link
Contributor

@0mdc 0mdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@aclegg3 aclegg3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Note this is breaking change since the flag is removed. Any code setting the flag elsewhere may error now.

@jturner65 jturner65 merged commit c544eea into main Sep 13, 2023
10 checks passed
@jturner65 jturner65 deleted the Hab3-0_CleanupRefactorsPBR branch September 13, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants