This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Add helper function "cv2_utils.findContours" to maintain version compatibility between versions 3 and 4 #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
fmassa
suggested changes
Jan 21, 2019
requirements.txt
Outdated
| @@ -0,0 +1,13 @@ | |||
| requests | |||
There was a problem hiding this comment.
When is the requirements file used? Let's maybe keep the diff minimal only with things that are related to the opencv fix?
|
and thanks for the PR by the way! |
|
Okay, I removed the other files / commits, so this PR is now only related to the I meant to change branches and was still working on this branch, and didn't realize that it was also my PR branch! All, should be good now. Please lmk if you have any other feedback? I did see the comment to support cv2 versions 1-4 in #336 's suggested snippet , but I thought maybe only versions 3-4 is relevant, so my code is for that. Thanks |
kris-singh
pushed a commit
to kris-singh/maskrcnn-benchmark
that referenced
this pull request
Jan 22, 2019
Lyears
pushed a commit
to Lyears/maskrcnn-benchmark
that referenced
this pull request
Jun 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small PR to fix the version compatibility problem with
cv2.findContoursreturning either 2 or 3 values depending on the cv2 version.I replaced all occurrences of
cv2.findContourswith the helper.I put the code in
utils/dir. Seemed like the best place for it, but please advise.Testing
I tested locally by installing my branch locally using:
Then ran the
demo/Mask_R-CNN_demo.ipynband it worked as expected, even though mycv2version isopencv-python==4.0.0.21, so this is now compatible with either version.References
fixes #336
#339 also referenced this error but the issue is already closed