Skip to content

Commit

Permalink
typing for unproject_points
Browse files Browse the repository at this point in the history
Summary: Fix the base class annotation for unproject_points.

Reviewed By: patricklabatut

Differential Revision: D33281586

fbshipit-source-id: 1c34e8c4b30b359fcb9307507bc778ad3fecf290
  • Loading branch information
bottler authored and facebook-github-bot committed Jan 24, 2022
1 parent 67778ca commit 5053142
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion pytorch3d/renderer/cameras.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def get_projection_transform(self):
"""
raise NotImplementedError()

def unproject_points(self):
def unproject_points(self, xy_depth: torch.Tensor, **kwargs):
"""
Transform input points from camera coodinates (NDC or screen)
to the world / camera coordinates.
Expand Down
2 changes: 1 addition & 1 deletion pytorch3d/renderer/implicit/raysampling.py
Original file line number Diff line number Diff line change
Expand Up @@ -549,7 +549,7 @@ def _xy_to_ray_bundle(
)

# unproject the points
unprojected = cameras.unproject_points(to_unproject, from_ndc=True) # pyre-ignore
unprojected = cameras.unproject_points(to_unproject, from_ndc=True)

# split the two planes back
rays_plane_1_world = unprojected[:, :n_rays_per_image]
Expand Down

0 comments on commit 5053142

Please sign in to comment.