Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slow speed when using estimate estimate_normals #988

Closed
syguan96 opened this issue Dec 12, 2021 · 5 comments
Closed

slow speed when using estimate estimate_normals #988

syguan96 opened this issue Dec 12, 2021 · 5 comments
Assignees
@bottler
Labels
potential-bug Potential bug to flag an issue that needs to be looked into Stale

Comments

@syguan96
Copy link

Given the shape of particles as [1, 104314, 3], I estimate their normals as follows:

Pointclouds(particles).estimate_normals(neighborhood_size=10)

However, I found the calculating process is extremely slow (more than 0.5 min). Is it normal?
@patricklabatut
Copy link
Contributor

Thanks for reporting this potential problem!

the calculating process is extremely slow (more than 0.5 min)

  1. Would you have comparison points with other libraries for a similar operation?
  2. What speed would you consider "normal"?
  3. Do you think the observed speed is specific to the data you have and if so, could you please share that data to allow us to fully reproduce?

@patricklabatut patricklabatut added the potential-bug Potential bug to flag an issue that needs to be looked into label Dec 14, 2021
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 14, 2022
@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@bottler bottler self-assigned this Jan 20, 2022
@bottler bottler reopened this Jan 20, 2022
facebook-github-bot pushed a commit that referenced this issue Jan 24, 2022
@bottler @facebook-github-bot
use workaround for points_normals
c2862ff 
Summary:
Use existing workaround for batched 3x3 symeig because it is faster than torch.symeig.

Added benchmark showing speedup. True = workaround.
```
Benchmark                Avg Time(μs)      Peak Time(μs) Iterations
--------------------------------------------------------------------------------
normals_True_3000            16237           17233             31
normals_True_6000            33028           33391             16
normals_False_3000        18623069        18623069              1
normals_False_6000        36535475        36535475              1
```

Should help #988

Reviewed By: nikhilaravi

Differential Revision: D33660585

fbshipit-source-id: d1162b277f5d61ed67e367057a61f25e03888dce
@github-actions
Copy link

This issue was closed because it has been stalled for 5 days with no activity.

@bottler
Copy link
Contributor

bottler commented Jan 26, 2022

(Just to explain: the commit c2862ff which is referenced should have made a big speedup.)

@Marigod98 Marigod98 mentioned this issue Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bottler bottler

Labels
potential-bug Potential bug to flag an issue that needs to be looked into Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bottler @patricklabatut @syguan96