Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add further customization ability to admonitions and details #2241

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

facelessuser
Copy link
Owner

  • Allow specifying a specific class that is not the same as the custom block name.
  • Allow specifying a default title that is not derived from the class.

Also remove some dead code that was used during development of the block feature.

@gir-bot gir-bot added S: needs-review Needs to be reviewed and/or approved. C: details Related to the details extension. C: docs Related to documentation. C: emoji Related to the emoji extension. C: infrastructure Related to project infrastructure. C: source Related to source code. labels Nov 19, 2023
- Allow specifying a specific class that is not the same as the custom
  block name.
- Allow specifying a default title that is not derived from the class.

Also remove some dead code that was used during development of the block
feature.
@facelessuser facelessuser force-pushed the feature/admon-details-customization branch from 7a4572f to 4c06996 Compare November 24, 2023 17:07
@gir-bot gir-bot added the C: tests Related to testing. label Nov 24, 2023
@facelessuser facelessuser marked this pull request as ready for review November 24, 2023 17:09
@facelessuser
Copy link
Owner Author

@gir-bot lgtm

@gir-bot gir-bot added S: approved The pull request is ready to be merged. and removed S: needs-review Needs to be reviewed and/or approved. labels Nov 24, 2023
@facelessuser facelessuser merged commit ee9fe14 into main Nov 24, 2023
16 checks passed
@facelessuser facelessuser deleted the feature/admon-details-customization branch November 24, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: details Related to the details extension. C: docs Related to documentation. C: emoji Related to the emoji extension. C: infrastructure Related to project infrastructure. C: source Related to source code. C: tests Related to testing. S: approved The pull request is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants