Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Detection Rule For Amazon Fire TV #471

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

jishidaaaaa
Copy link

Fixed because it was not judged correctly in the latest model.

@@ -448,7 +448,7 @@
], [MODEL, [VENDOR, 'Amazon'], [TYPE, TABLET]], [
/(sd|kf)[0349hijorstuw]+(\sbuild\/|\)).+silk\//i // Fire Phone
], [[MODEL, mapper.str, maps.device.amazon.model], [VENDOR, 'Amazon'], [TYPE, MOBILE]], [
/android.+aft([bms])\sbuild/i // Fire TV
/android.+aft([\w])(\sbuild\/|\))/i // Fire TV
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.amazon.com/docs/fire-tv/user-agent-strings.html

with a device model that starts with "AFT".

According to the document, It is correct to judge by any single character following "AFT"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supports both with and without "build"

@@ -1219,6 +1219,15 @@
"type": "smarttv"
}
},
{
"desc": "Amazon Fire TV",
"ua": "Mozilla/5.0 (Linux; Android 5.1.1; AFTT) AppleWebKit/537.36 (KHTML, like Gecko) Silk/86.3.20 like Chrome/86.0.4240.198 Safari/537.36",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is actual user agent.

@faisalman faisalman changed the base branch from master to develop January 5, 2021 16:46
@faisalman faisalman merged commit 89a72c2 into faisalman:develop Jan 5, 2021
@jishidaaaaa jishidaaaaa deleted the fix-firetv-detection branch January 6, 2021 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants