Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): add states for Croatia (hr) #2142

Merged
merged 6 commits into from
Sep 10, 2023

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer requested a review from a team as a code owner May 9, 2023 06:07
@matthewmayer matthewmayer self-assigned this May 9, 2023
@matthewmayer matthewmayer added c: feature Request for new feature p: 1-normal Nothing urgent m: location Something is referring to the location module labels May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #2142 (16e3b9e) into next (604d52d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2142   +/-   ##
=======================================
  Coverage   99.60%   99.61%           
=======================================
  Files        2784     2786    +2     
  Lines      252492   252522   +30     
  Branches     1082     1085    +3     
=======================================
+ Hits       251496   251544   +48     
+ Misses        969      951   -18     
  Partials       27       27           
Files Changed Coverage Δ
src/locales/hr/location/county.ts 100.00% <100.00%> (ø)
src/locales/hr/location/index.ts 100.00% <100.00%> (ø)
src/locales/hr/location/state.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be best to just call them counties here.
As for states we could use these https://en.wikipedia.org/wiki/Regions_of_Croatia or omit them entirely.

src/locales/hr/location/state.ts Show resolved Hide resolved
@xDivisionByZerox xDivisionByZerox added the c: locale Permutes locale definitions label Jul 2, 2023
@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Jul 14, 2023
@ST-DDT
Copy link
Member

ST-DDT commented Aug 31, 2023

Team Decision

We will jump to a definition loophole and will put it in both state (as first level administrative unit) and in county (as county names).

We will create a separate issue to clarify that states ~= ISO_3166-2

@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Aug 31, 2023
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put these in both state and county. County should import state.

@matthewmayer matthewmayer requested review from ST-DDT and a team September 1, 2023 01:42
@ST-DDT ST-DDT requested review from a team September 1, 2023 06:38
@xDivisionByZerox xDivisionByZerox merged commit 8a6ce49 into faker-js:next Sep 10, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent
Projects
No open projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants