Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): remove continent from ja countries #2194

Merged

Conversation

KeisukeYamashita
Copy link
Contributor

Hello, sorry for the bothering 🙏

I noticed that there are many continents in the country list.

I would like to remove it because the dummy data for user profiles in the service, as it generates strange profiles, such as Antarctica as the country of residence.

Thank you in advance.

@KeisukeYamashita KeisukeYamashita marked this pull request as ready for review June 2, 2023 05:28
@KeisukeYamashita KeisukeYamashita requested a review from a team as a code owner June 2, 2023 05:28
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #2194 (6a74460) into next (e4a6bfe) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2194      +/-   ##
==========================================
- Coverage   99.60%   99.59%   -0.01%     
==========================================
  Files        2607     2607              
  Lines      245029   245021       -8     
  Branches     1154     1151       -3     
==========================================
- Hits       244049   244030      -19     
- Misses        953      964      +11     
  Partials       27       27              
Impacted Files Coverage Δ
src/locales/ja/location/country.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@import-brain import-brain added p: 1-normal Nothing urgent c: locale Permutes locale definitions labels Jun 4, 2023
@import-brain
Copy link
Member

Translated the removed continents to English to check, lgtm 👍

@ST-DDT ST-DDT merged commit cdd162a into faker-js:next Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions p: 1-normal Nothing urgent
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants