Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): prefer-number-properties #2452

Merged
merged 11 commits into from
Oct 21, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 9, 2023

@ST-DDT ST-DDT added the c: infra Changes to our infrastructure or project setup label Oct 9, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 9, 2023
@ST-DDT ST-DDT requested review from a team October 9, 2023 10:26
@ST-DDT ST-DDT self-assigned this Oct 9, 2023
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Oct 9, 2023
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #2452 (323c07f) into next (8540381) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2452      +/-   ##
==========================================
- Coverage   99.59%   99.58%   -0.01%     
==========================================
  Files        2823     2823              
  Lines      255517   255520       +3     
  Branches     1104     1101       -3     
==========================================
- Hits       254479   254459      -20     
- Misses       1010     1033      +23     
  Partials       28       28              
Files Coverage Δ
src/modules/commerce/index.ts 100.00% <100.00%> (ø)
src/modules/date/index.ts 100.00% <100.00%> (ø)
src/modules/helpers/index.ts 98.99% <100.00%> (+<0.01%) ⬆️
src/modules/helpers/luhn-check.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team October 9, 2023 13:03
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I didn't even knew that global isNaN() coerces inputs which do not match the 'number' type . Interesting rule!

matthewmayer
matthewmayer previously approved these changes Oct 9, 2023
import-brain
import-brain previously approved these changes Oct 9, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) October 9, 2023 18:18
@ST-DDT ST-DDT disabled auto-merge October 9, 2023 18:23
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Oct 9, 2023
@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Oct 9, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) October 21, 2023 06:49
@ST-DDT ST-DDT merged commit f222448 into next Oct 21, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/prefer-number-properties branch October 22, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants