Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra(unicorn): no-array-reduce #2479

Merged
merged 19 commits into from
Nov 7, 2023
Merged

infra(unicorn): no-array-reduce #2479

merged 19 commits into from
Nov 7, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Oct 15, 2023 •
edited
Loading

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Oct 15, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Oct 15, 2023
@ST-DDT ST-DDT requested review from a team October 15, 2023 11:25
@ST-DDT ST-DDT self-assigned this Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023 •
edited
Loading

Codecov Report

Merging #2479 (5a76bd6) into next (9498203) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2479      +/-   ##
==========================================
- Coverage   99.58%   99.57%   -0.01%     
==========================================
  Files        2778     2779       +1     
  Lines      249254   249273      +19     
  Branches     1081     1079       -2     
==========================================
+ Hits       248214   248219       +5     
- Misses       1012     1026      +14     
  Partials       28       28
Files Coverage Δ
src/internal/group-by.ts 100.00% <100.00%> (ø)
src/modules/word/filter-word-list-by-length.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT mentioned this pull request Oct 15, 2023
Open
xDivisionByZerox
xDivisionByZerox requested changes Oct 22, 2023
View reviewed changes
test/all_functional.spec.ts Outdated Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
src/modules/word/filterWordListByLength.ts Outdated Show resolved Hide resolved
xDivisionByZerox
xDivisionByZerox previously approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining suggestions are optional. Thats why I'll already approve.

test/all_functional.spec.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team October 26, 2023 19:02
@ST-DDT ST-DDT requested a review from a team October 28, 2023 20:24
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team November 6, 2023 09:47
@ST-DDT ST-DDT enabled auto-merge (squash) November 7, 2023 16:18
@ST-DDT ST-DDT merged commit 8542ef3 into next Nov 7, 2023
20 checks passed
@ST-DDT ST-DDT deleted the infra/unicorn/no-array-reduce branch November 9, 2023 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Milestone
vAnytime
Development

Successfully merging this pull request may close these issues.
2 participants
@ST-DDT @xDivisionByZerox