Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(person): remove duplicate title definitions #2523

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

matthewmayer
Copy link
Contributor

Extracted from #2505

#2505 (comment)

If the job_title definitions etc are just exact copies of en, remove them and allow the standard fallback to en.

@matthewmayer matthewmayer requested a review from a team as a code owner November 2, 2023 02:58
@matthewmayer matthewmayer changed the title refactor(person): remove he,pl,sk title definitions which are duplicates of en refactor(person): remove he,pl,sk,cs_CZ title definitions which are duplicates of en Nov 2, 2023
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #2523 (f2ed3b5) into next (0ad88a6) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2523      +/-   ##
==========================================
- Coverage   99.59%   99.58%   -0.01%     
==========================================
  Files        2823     2819       -4     
  Lines      255507   255135     -372     
  Branches     1105     1098       -7     
==========================================
- Hits       254465   254075     -390     
- Misses       1014     1032      +18     
  Partials       28       28              
Files Coverage Δ
src/locales/cs_CZ/person/index.ts 100.00% <ø> (ø)
src/locales/he/person/index.ts 100.00% <ø> (ø)
src/locales/pl/person/index.ts 100.00% <ø> (ø)
src/locales/sk/person/index.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

@matthewmayer matthewmayer self-assigned this Nov 2, 2023
@matthewmayer matthewmayer added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: person Something is referring to the person module labels Nov 2, 2023
@matthewmayer matthewmayer added this to the v8.x milestone Nov 2, 2023
@ST-DDT ST-DDT requested review from a team November 2, 2023 06:37
@ST-DDT ST-DDT changed the title refactor(person): remove he,pl,sk,cs_CZ title definitions which are duplicates of en refactor(person): remove duplicate title definitions Nov 3, 2023
@ST-DDT ST-DDT enabled auto-merge (squash) November 3, 2023 23:36
@ST-DDT ST-DDT merged commit 22003bb into faker-js:next Nov 3, 2023
20 checks passed
matthewmayer added a commit to matthewmayer/faker that referenced this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: person Something is referring to the person module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants