feat(person): add job titles for fr #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the new job_title_pattern to add job titles with a logical order for French e.g. ``` Coordinateur en chef de la tactique Executif central des facteurs Stagiaire corporate des marchés ``` Due to the need to translate “of” in French to de, de la, des, du, etc depending on the number and gender of the noun, this is incorporated into the level definitions. The fr_BE and fe_CH definitions are deleted so the standard fr ones can fall through.
matthewmayer
added
m: person
|
@makhtar-sarr if you're available to help review this (i'm not a native French speaker) that would be appreciated! |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2531 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 2806 2805 -1
Lines 250060 250069 +9
Branches 1100 1098 -2
=======================================
+ Hits 248993 249002 +9
Misses 1039 1039
Partials 28 28
|
makhtar-sarr
reviewed
Nov 8, 2023
ST-DDT
approved these changes
Nov 10, 2023
|
@matthewmayer Is this ready for merge? |
|
Yes |
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the new job_title_pattern to add job titles with a logical order for French e.g.
Due to the need to translate “of” in French to de, de la, des, du, etc depending on the number and gender of the noun, this is incorporated into the level definitions.
The fr_BE and fe_CH definitions are deleted so the standard fr ones can fall through.