Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change Ecosystem heading to Try it #2544

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

matthewmayer
Copy link
Contributor

Changes Ecosystem to the more compelling "Try it"

fix #2426

#2426 (comment)

@matthewmayer matthewmayer requested a review from a team November 13, 2023 12:24
@matthewmayer matthewmayer requested a review from a team as a code owner November 13, 2023 12:24
@matthewmayer matthewmayer self-assigned this Nov 13, 2023
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2544 (6cfb3e9) into next (1328985) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 6cfb3e9 differs from pull request most recent head e238390. Consider uploading reports for the commit e238390 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2544      +/-   ##
==========================================
+ Coverage   99.57%   99.58%   +0.01%     
==========================================
  Files        2806     2801       -5     
  Lines      250060   249908     -152     
  Branches     1098     1084      -14     
==========================================
- Hits       248991   248869     -122     
+ Misses       1041     1011      -30     
  Partials       28       28              

see 16 files with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Nov 13, 2023

I also would like to rename the PR a bit, but I'm not sure about the wording:

-> docs: change Ecosystem header to Try it

@ST-DDT ST-DDT added this to the vAnytime milestone Nov 13, 2023
@ST-DDT ST-DDT requested review from a team November 13, 2023 13:34
@matthewmayer matthewmayer changed the title docs: change Ecosystem to Try it docs: change Ecosystem heading to Try it Nov 13, 2023
@xDivisionByZerox
Copy link
Member

Other websites usually have a "playground" link in their navigation. Would that work for us as well?

@ST-DDT
Copy link
Member

ST-DDT commented Nov 14, 2023

@matthewmayer, @import-brain : What do you think about naming it Playground? Or do you prefer Try it?

Team Notice

  • In the future we will have a new Ecosystem menu that links to other Faker implementations and related tools.

@import-brain
Copy link
Member

@matthewmayer, @import-brain : What do you think about naming it Playground? Or do you prefer Try it?

Team Notice

  • In the future we will have a new Ecosystem menu that links to other Faker implementations and related tools.

I would prefer "Try it", it seems slightly more friendly.

@matthewmayer
Copy link
Contributor Author

I also prefer Try it

@xDivisionByZerox
Copy link
Member

I'm fine with that. But I wanted to have feedback from you first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window.faker on faker.dev website
4 participants