chore(deps): update eslint-define-config #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shinigami92
added
the
c: dependencies
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2551 +/- ##
==========================================
- Coverage 99.57% 99.57% -0.01%
==========================================
Files 2805 2805
Lines 250088 250088
Branches 1099 1099
==========================================
- Hits 249033 249030 -3
- Misses 1027 1030 +3
Partials 28 28 |
Shinigami92
force-pushed
the
update-eslint-define-config
branch
from
041d691
to
93aa8f3
Compare
What does that imply for our repository? |
Nothing special, just that right there is no type-check and auto-completion for vitest rules until they ship support |
ST-DDT
approved these changes
Nov 17, 2023
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade
eslint-define-configto v2.0.0 with new community driven type support systemCurrently there is not vitest rules support, I can try add that to vitest directly