Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(finance): correct VG IBAN format #2552

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

Alexnagel
Copy link
Contributor

The current generated Virgin Islands IBAN format is invalid. It generates an invalid bank code.
VG46H07Y0223060094359858 The bold part should be 4 non numeric characters.

See below links for the correct format:
https://www.mobilefish.com/services/random_iban_generator/random_iban_generator.php
https://wise.com/gb/iban/british-virgin-islands

@Alexnagel Alexnagel requested a review from a team as a code owner November 17, 2023 16:26
@Alexnagel Alexnagel changed the title fix(finance) Correct VG IBAN format fix(finance): Correct VG IBAN format Nov 17, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Nov 17, 2023
@ST-DDT ST-DDT added c: bug Something isn't working p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Nov 17, 2023
Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2552 (2fafe7e) into next (ba28ab6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2552   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files        2805     2805           
  Lines      250069   250069           
  Branches     1101     1100    -1     
=======================================
+ Hits       249004   249008    +4     
+ Misses       1037     1033    -4     
  Partials       28       28           
Files Coverage Δ
src/modules/finance/iban.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT
Copy link
Member

ST-DDT commented Nov 18, 2023

I also created a PR in validatorjs to propagate the validation upstream:

@ST-DDT ST-DDT requested review from a team November 18, 2023 10:34
@ST-DDT ST-DDT changed the title fix(finance): Correct VG IBAN format fix(finance): correct VG IBAN format Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: bug Something isn't working m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants