Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(eslint): prefer-exponentiation-operator #2585

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Dec 20, 2023

Enables the prefer-exponentiation-operator lint rule.


Currently there are 6 places that use x ** y and zero places that use Math.pow(x, y).
Enabling this rule should keep the code consistent in the future.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Dec 20, 2023
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 20, 2023
@ST-DDT ST-DDT requested review from a team December 20, 2023 13:41
@ST-DDT ST-DDT self-assigned this Dec 20, 2023
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3649b89) 99.58% compared to head (f31c358) 99.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2585      +/-   ##
==========================================
- Coverage   99.58%   99.57%   -0.01%     
==========================================
  Files        2806     2806              
  Lines      250195   250195              
  Branches     1109     1105       -4     
==========================================
- Hits       249145   249131      -14     
- Misses       1022     1036      +14     
  Partials       28       28              

see 2 files with indirect coverage changes

@xDivisionByZerox
Copy link
Member

This is an addition to the recommended unicorn preset?

@ST-DDT
Copy link
Member Author

ST-DDT commented Dec 20, 2023

This is an addition to the recommended unicorn preset?

This is an addition to eslint's recommended rule set, not unicorn's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants