Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update license year #2594

Merged
merged 5 commits into from
Jan 2, 2024
Merged

chore: update license year #2594

merged 5 commits into from
Jan 2, 2024

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added the c: chore PR that doesn't affect the runtime behavior label Jan 1, 2024
@Shinigami92 Shinigami92 self-assigned this Jan 1, 2024
@Shinigami92 Shinigami92 requested a review from a team as a code owner January 1, 2024 12:36
Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (de5d07e) 99.57% compared to head (cfe23b0) 99.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2594      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2807     2807              
  Lines      250401   250401              
  Branches     1144     1141       -3     
==========================================
- Hits       249338   249335       -3     
- Misses       1035     1038       +3     
  Partials       28       28              

see 2 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Jan 1, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Jan 1, 2024
@ST-DDT ST-DDT requested review from a team January 1, 2024 12:56
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe could remove the copyright statement from the user agent and mersenne files and just leave it in LICENSE so it's only in one place?

@ST-DDT
Copy link
Member

ST-DDT commented Jan 1, 2024

Or at least our copyright year.

@Shinigami92
Copy link
Member Author

I was now shown various options for changing something that would have to be changed once a year and adjusting 3 lines. I would not like to get involved in discussions and waste potential time researching whether and where license years are required and where not. If this is really that important to you, then it's best to open your own PR and close this one if necessary.

LICENSE Outdated Show resolved Hide resolved
@matthewmayer
Copy link
Contributor

I agree it is an annoying discussion BUT copyright is important. Rather than blindly updating the year once a year it's important we understand what the copyright statement actually means and if it applies to specific files or the whole repo.

@Shinigami92
Copy link
Member Author

I agree it is an annoying discussion BUT copyright is important. Rather than blindly updating the year once a year it's important we understand what the copyright statement actually means and if it applies to specific files or the whole repo.

So you suggest to only touch the specific files if their content changes?
And in this PR I should revert the specific files and only bump the LICENSE file in root?

@matthewmayer
Copy link
Contributor

I'd bump the root one and look into the history of the other files to see if there is some special reason why they have seperate copyright statements. If not they should just be removed as they don't serve any purpose.

src/internal/mersenne.ts Outdated Show resolved Hide resolved
src/modules/internet/user-agent.ts Outdated Show resolved Hide resolved
@Shinigami92
Copy link
Member Author

I'd bump the root one and look into the history of the other files to see if there is some special reason why they have seperate copyright statements. If not they should just be removed as they don't serve any purpose.

So I reset the specific files and left the other task to someone who has the will to do it

@Shinigami92 Shinigami92 enabled auto-merge (squash) January 2, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: chore PR that doesn't affect the runtime behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants