Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency prettier to v3.2.4 #2615

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jan 22, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
prettier (source) 3.2.2 -> 3.2.4 age adoption passing confidence

Release Notes

prettier/prettier (prettier)

v3.2.4

Compare Source

diff

Fix incorrect parser inference (#​15947 by @​fisker)

Files like .eslintrc.json were incorrectly formatted as JSONC files.

// Input
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "jsonc" }

// Prettier 3.2.4
prettier --file-info .eslintrc.json
{ "ignored": false, "inferredParser": "json" }

v3.2.3

Compare Source

diff

Throw errors for invalid code (#​15881 by @​fisker, @​Josh-Cena, @​auvred)
// Input
1++;

// Prettier 3.2.2
1++;

// Prettier 3.2.3
SyntaxError: Invalid left-hand side expression in unary operation (1:1)
> 1 | 1++;
    | ^
// Input
try {} catch (error = 1){}

// Prettier 3.2.2
try {
} catch (error) {}

// Prettier 3.2.3
SyntaxError: Catch clause variable cannot have an initializer. (1:23)
> 1 | try {} catch (error = 1){}
    |                       ^
Fix parser inference (#​15927 by @​fisker)
// Prettier 3.2.2
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "json" }

// Prettier 3.2.3
prettier --file-info tsconfig.json
{ "ignored": false, "inferredParser": "jsonc" }

Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner January 22, 2024 00:48
@renovate renovate bot added the c: dependencies Pull requests that adds/updates a dependency label Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (234218b) 99.57% compared to head (325162d) 99.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2615      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2807     2807              
  Lines      250441   250441              
  Branches     1153     1151       -2     
==========================================
- Hits       249380   249370      -10     
- Misses       1033     1043      +10     
  Partials       28       28              

see 1 file with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Jan 22, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Jan 22, 2024

grafik
grafik

Is this intentionally?

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index b03aff9ab..7bd11afff 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -11,8 +11,8 @@
   "forwardPorts": [5173],
   "portsAttributes": {
     "5173": {
-      "label": "Docs"
-    }
+      "label": "Docs",
+    },
   },

   // Use 'postCreateCommand' to run commands after the container is created.
@@ -26,10 +26,10 @@
         "editorconfig.editorconfig",
         "esbenp.prettier-vscode",
:...skipping...
diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index b03aff9ab..7bd11afff 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -11,8 +11,8 @@
   "forwardPorts": [5173],
   "portsAttributes": {
     "5173": {
-      "label": "Docs"
-    }
+      "label": "Docs",
+    },
   },

   // Use 'postCreateCommand' to run commands after the container is created.
@@ -26,10 +26,10 @@
         "editorconfig.editorconfig",
         "esbenp.prettier-vscode",
         "redhat.vscode-yaml",
-        "github.vscode-pull-request-github"
-      ]
-    }
-  }
+        "github.vscode-pull-request-github",
+      ],
+    },
+  },

   // Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
   // "remoteUser": "root"
diff --git a/cypress/tsconfig.json b/cypress/tsconfig.json
index 0446ab750..1071e2eb5 100644
--- a/cypress/tsconfig.json
+++ b/cypress/tsconfig.json
@@ -5,7 +5,7 @@
     "types": ["cypress"],
     "esModuleInterop": true,
     "noEmit": true,
-    "resolveJsonModule": true
+    "resolveJsonModule": true,
   },
-  "include": ["**/*.ts"]
+  "include": ["**/*.ts"],
 }
diff --git a/tsconfig.json b/tsconfig.json
index a290fc07b..020c97429 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -11,12 +11,12 @@
     // These are configs specifically for !build and have to be reverted in the tsconfig.build.json
     "skipLibCheck": true,
     "allowSyntheticDefaultImports": true,
-    "resolveJsonModule": true
+    "resolveJsonModule": true,
   },
   "exclude": [
     "node_modules",
     "dist",
     // required for the typedoc related tests on macOS #2280
-    "test/scripts/apidoc/temp"
-  ]
+    "test/scripts/apidoc/temp",
+  ],
 }

@ST-DDT ST-DDT added this to the vAnytime milestone Jan 22, 2024
@xDivisionByZerox
Copy link
Member

I usually have this setting in my private projects as well, as this reduces git diffs when adding/removing to arrays/objects. While this works in most IDEs, strict json parsers will throw as dangling commas are not part of the official json standard.

Shinigami92
Shinigami92 previously approved these changes Jan 22, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Jan 22, 2024

My question was more whether the tools using those files, officially support it or just happen to ignore it. And whether we should change our files accordingly.

@ST-DDT ST-DDT dismissed stale reviews from Shinigami92 and themself via 325162d January 22, 2024 18:39
@ST-DDT
Copy link
Member

ST-DDT commented Jan 22, 2024

CI passes and devcontainers still work...

Copy link
Contributor Author

renovate bot commented Jan 22, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants