Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: override default vitepress brand colors #2632

Merged
merged 4 commits into from
Feb 5, 2024

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Jan 29, 2024

fix #2626

Originally I was going to make it green but i think red looks quite nice (took the hue from the Faker logo, the saturation and lightness values are from the default Vitepress theme).

Screenshot 2024-01-29 at 07 40 46 Screenshot 2024-01-29 at 07 40 50 Screenshot 2024-01-29 at 07 41 02 () Screenshot 2024-01-29 at 07 40 57

@matthewmayer matthewmayer requested a review from a team January 29, 2024 00:43
@matthewmayer matthewmayer requested a review from a team as a code owner January 29, 2024 00:43
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1987ef) 99.57% compared to head (fad558c) 99.57%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2632      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2807     2807              
  Lines      250489   250489              
  Branches     1154     1152       -2     
==========================================
- Hits       249430   249420      -10     
- Misses       1031     1041      +10     
  Partials       28       28              

see 1 file with indirect coverage changes

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: needs decision Needs team/maintainer decision c: infra Changes to our infrastructure or project setup labels Jan 29, 2024
@ST-DDT ST-DDT added this to the v8.x milestone Jan 29, 2024
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The faker title looks quite pink on the dark background, and the difference to the button is very visible.

grafik

@matthewmayer
Copy link
Contributor Author

I think maybe decide first in the meeting if you prefer red green or blue in general, and then I can tweak the colours to make it look nice everywhere.

@ST-DDT
Copy link
Member

ST-DDT commented Feb 1, 2024

Team Decision

  • We decided to stick to the green design for now.
  • We can rethink our "corporate"/brand design later, currently we are too busy for that and it needs to be done for more than the website.

@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Feb 1, 2024
@matthewmayer
Copy link
Contributor Author

Back to a green design similar to the old theme

Screenshot 2024-02-04 at 14 39 02 Screenshot 2024-02-04 at 14 38 58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title and buttons on homepage have gone blue?
4 participants