Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify that the result of faker.date.betweens() is sorted #2635

Merged
merged 4 commits into from
Feb 6, 2024

Conversation

matthewmayer
Copy link
Contributor

Inspired by #2633 - wasn't obvious from the docs that the result was sorted.

Inspired by #2633 - wasn't obvious from the docs that the result was sorted.
@matthewmayer matthewmayer requested a review from a team as a code owner January 30, 2024 00:30
@matthewmayer matthewmayer self-assigned this Jan 30, 2024
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation m: date Something is referring to the date module labels Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (45b012e) 99.57% compared to head (7dcd7e2) 99.57%.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2635    +/-   ##
========================================
  Coverage   99.57%   99.57%            
========================================
  Files        2807     2807            
  Lines      250525   250525            
  Branches      744     1149   +405     
========================================
+ Hits       249454   249455     +1     
+ Misses       1071     1042    -29     
- Partials        0       28    +28     
Files Coverage Δ
src/modules/date/index.ts 99.92% <100.00%> (ø)

... and 29 files with indirect coverage changes

@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Jan 30, 2024
src/modules/date/index.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added this to the vAnytime milestone Jan 30, 2024
@ST-DDT ST-DDT requested review from a team February 5, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation m: date Something is referring to the date module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants