Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(unicorn): prefer-at #2654

Merged
merged 9 commits into from
Feb 19, 2024
Merged

infra(unicorn): prefer-at #2654

merged 9 commits into from
Feb 19, 2024

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent breaking change Cannot be merged when next version is not a major release c: infra Changes to our infrastructure or project setup labels Feb 9, 2024
@Shinigami92 Shinigami92 added this to the v9.0 milestone Feb 9, 2024
@Shinigami92 Shinigami92 self-assigned this Feb 9, 2024
@Shinigami92 Shinigami92 marked this pull request as ready for review February 9, 2024 18:49
@Shinigami92 Shinigami92 requested a review from a team February 9, 2024 18:49
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 9, 2024 18:49
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fd31ec6) 99.55% compared to head (0604f7e) 99.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2654   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files        2817     2817           
  Lines      251202   251203    +1     
  Branches     1123     1126    +3     
=======================================
+ Hits       250090   250096    +6     
+ Misses       1083     1078    -5     
  Partials       29       29           
Files Coverage Δ
src/modules/helpers/index.ts 98.91% <0.00%> (-0.07%) ⬇️

... and 1 file with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Feb 9, 2024
@ST-DDT ST-DDT requested review from a team February 9, 2024 19:29
@ST-DDT
Copy link
Member

ST-DDT commented Feb 9, 2024

IMO this isn't breaking for the same reasons as outlined there: #2653 (comment)

@Shinigami92 Shinigami92 changed the title infra(unicorn)!: prefer-at infra(unicorn): prefer-at Feb 9, 2024
docs/guide/upgrading_v9/2654.md Show resolved Hide resolved
docs/guide/upgrading_v9/2121.md Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Feb 16, 2024
@ST-DDT ST-DDT requested review from a team February 16, 2024 15:41

Used Node >= v16.6 feature [`at`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at).

We could hint users to use polyfill or transpile-down steps.
Copy link
Member

@ST-DDT ST-DDT Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note from my future me: We will have at most a very minimum description of "how to transpile down for node < x". I won't help them shoot themselves in the foot and complain to us about it.

And I won't keep track of any node <18 feature usage myself unless specifically requested by our community.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are stuck using node 14/16 you should just stay on faker@8 rather than try to transpile things.

import-brain
import-brain previously approved these changes Feb 17, 2024
@Shinigami92 Shinigami92 dismissed stale reviews from import-brain and ST-DDT via 3458af5 February 18, 2024 22:17
@ST-DDT ST-DDT added the needs rebase There is a merge conflict label Feb 18, 2024
@Shinigami92 Shinigami92 enabled auto-merge (squash) February 19, 2024 09:48
@Shinigami92 Shinigami92 dismissed matthewmayer’s stale review February 19, 2024 10:07

The requested changes were already resolved

@ST-DDT ST-DDT removed the needs rebase There is a merge conflict label Feb 19, 2024
@ST-DDT ST-DDT requested review from a team February 19, 2024 10:08
@Shinigami92 Shinigami92 enabled auto-merge (squash) February 19, 2024 10:08
@Shinigami92 Shinigami92 merged commit 9882760 into next Feb 19, 2024
16 of 17 checks passed
@Shinigami92 Shinigami92 deleted the infra/unicorn/prefer-at branch February 19, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Cannot be merged when next version is not a major release c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants