Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update README to indicate next.fakerjs.dev will be v9 #2657

Merged
merged 1 commit into from
Feb 10, 2024
Merged

docs: update README to indicate next.fakerjs.dev will be v9 #2657

merged 1 commit into from
Feb 10, 2024

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Feb 10, 2024 •
edited
Loading

image

@matthewmayer matthewmayer requested a review from a team February 10, 2024 03:15
@matthewmayer matthewmayer requested a review from a team as a code owner February 10, 2024 03:15
@codecov Codecov
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc3ebb7) 99.57% compared to head (5de5a03) 99.56%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2657      +/-   ##
==========================================
- Coverage   99.57%   99.56%   -0.01%     
==========================================
  Files        2807     2807              
  Lines      250526   250526              
  Branches     1153     1149       -4     
==========================================
- Hits       249464   249444      -20     
- Misses       1034     1054      +20     
  Partials       28       28

see 2 files with indirect coverage changes

@matthewmayer matthewmayer added the c: docs Improvements or additions to documentation label Feb 10, 2024
@ST-DDT ST-DDT requested review from a team February 10, 2024 07:51
@ST-DDT ST-DDT added this to the v9.0 milestone Feb 10, 2024
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Feb 10, 2024
@ST-DDT ST-DDT requested a review from a team February 10, 2024 11:16
@xDivisionByZerox xDivisionByZerox merged commit cdf0bb6 into faker-js:next Feb 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.
4 participants
@matthewmayer @ST-DDT @Shinigami92 @xDivisionByZerox