Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more jsdoc fixes #2668

Merged
merged 4 commits into from
Feb 19, 2024
Merged

docs: more jsdoc fixes #2668

merged 4 commits into from
Feb 19, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 18, 2024

Some more jsdoc fixes with some additional jsdocs extensions required for #2628

Should I split the extensions to a different PR?

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Feb 18, 2024
@ST-DDT ST-DDT added this to the v9.0 milestone Feb 18, 2024
@ST-DDT ST-DDT requested review from a team February 18, 2024 11:04
@ST-DDT ST-DDT self-assigned this Feb 18, 2024
Copy link

codecov bot commented Feb 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (accf42c) 99.56% compared to head (e32b5d3) 99.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2668      +/-   ##
==========================================
- Coverage   99.56%   99.54%   -0.02%     
==========================================
  Files        2817     2817              
  Lines      251203   251208       +5     
  Branches     1129     1120       -9     
==========================================
- Hits       250105   250074      -31     
- Misses       1098     1134      +36     
Files Coverage Δ
src/faker.ts 90.00% <100.00%> (+0.06%) ⬆️
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/helpers/index.ts 98.91% <100.00%> (ø)
src/modules/internet/index.ts 100.00% <100.00%> (ø)
src/modules/location/index.ts 99.20% <100.00%> (ø)
src/utils/merge-locales.ts 100.00% <100.00%> (ø)
src/randomizer.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT merged commit 25f2a03 into next Feb 19, 2024
16 checks passed
@ST-DDT ST-DDT deleted the jsdoc/more-fixes branch February 19, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't use deprecated phone.numer(format) parameter as an example for faker.helpers.fake
3 participants