Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: don't remove pnpm-lock on clean #2676

Merged
merged 1 commit into from
Feb 22, 2024
Merged

infra: don't remove pnpm-lock on clean #2676

merged 1 commit into from
Feb 22, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 21, 2024

IIRC this was mentioned in some release related discussions.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Feb 21, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Feb 21, 2024
@ST-DDT ST-DDT requested review from a team February 21, 2024 18:44
@ST-DDT ST-DDT self-assigned this Feb 21, 2024
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d89b348) 99.55% compared to head (5344e81) 99.55%.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2676    +/-   ##
========================================
  Coverage   99.55%   99.55%            
========================================
  Files        2817     2817            
  Lines      251188   251188            
  Branches      717     1117   +400     
========================================
  Hits       250072   250072            
  Misses       1087     1087            
  Partials       29       29            

see 1 file with indirect coverage changes

@Shinigami92
Copy link
Member

This would result in non-updated deeps sub-dev-dependencies.
We should verify that renovate does a deep upgrade for the lock file.
However this does not affect the released content at all and is just a thing for contributor using the faker repository while developing, cause the lock file is not shipped when publishing to the npm-registry.

@ST-DDT
Copy link
Member Author

ST-DDT commented Feb 21, 2024

This would result in non-updated deeps sub-dev-dependencies. We should verify that renovate does a deep upgrade for the lock file. However this does not affect the released content at all and is just a thing for contributor using the faker repository while developing, cause the lock file is not shipped when publishing to the npm-registry.

I created #2677 to address that.

@ST-DDT ST-DDT requested review from a team February 21, 2024 19:19
@ST-DDT ST-DDT merged commit 3853eac into next Feb 22, 2024
20 checks passed
@ST-DDT ST-DDT deleted the infra/pnpm/clean branch February 22, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants