infra(ci): highlight preflight diff errors in github #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 1-normal
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2684 +/- ##
========================================
Coverage 99.55% 99.55%
========================================
Files 2816 2816
Lines 250918 250918
Branches 704 1105 +401
========================================
+ Hits 249798 249812 +14
- Misses 1091 1106 +15
+ Partials 29 0 -29 |
This reverts commit 881ebf5.
Shinigami92
approved these changes
Feb 24, 2024
xDivisionByZerox
approved these changes
Feb 24, 2024
import-brain
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should create a GH error message for failed preflight files/files that have a diff after preflight.