test(finance): fix tests for amount

[ST-DDT]

This PR fixes a rare bug in the finance tests, that cause them to fail when amount returns 0.

Previously the tests checked for 0 < amount < 1001
Now the check looks like this: 0 <= amount <= 1000

I also removed the dedicated it returns a string test in favor of more checks in the other tests.
And I removed some description texts, because they state the exact same as the check itself.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (ccd7054) to head (a17196c).

❗ Current head a17196c differs from pull request most recent head fdeb70e. Consider uploading reports for the commit fdeb70e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2702      +/-   ##
==========================================
+ Coverage   99.56%   99.57%   +0.01%     
==========================================
  Files        2859     2859              
  Lines      248915   248878      -37     
  Branches      986      630     -356     
==========================================
- Hits       247837   247827      -10     
+ Misses       1078     1022      -56     
- Partials        0       29      +29     

see 38 files with indirect coverage changes

[Shinigami92]

@xDivisionByZerox I would like if you could take a look on this and approve accordingly
Because I'm not fully sure if 0 was an intended result or not

[xDivisionByZerox]

@xDivisionByZerox I would like if you could take a look on this and approve accordingly
Because I'm not fully sure if 0 was an intended result or not

Since the implementation did not change, this looks valid to me.

---

Additionally, I don't see why we should disallow 0 as return value. WHat would happen if the user provides 0 as min AND max value to the function?