Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: verify locale code is format in metadata #2713

Merged
merged 4 commits into from
Mar 5, 2024

Conversation

matthewmayer
Copy link
Contributor

fix #2710

Verifies that the metadata code is language_country_variant (skipping any missing parts).

this would catch, for example, mismatch between uz_UZ and uz_UZ_latin

@matthewmayer matthewmayer requested a review from a team as a code owner March 4, 2024 13:20
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (next@660da4c). Click here to learn what that means.

❗ Current head 2e1c4ad differs from pull request most recent head 58d72a8. Consider uploading reports for the commit 58d72a8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2713   +/-   ##
=======================================
  Coverage        ?   99.58%           
=======================================
  Files           ?     2859           
  Lines           ?   249642           
  Branches        ?     1010           
=======================================
  Hits            ?   248601           
  Misses          ?     1012           
  Partials        ?       29           

test/locale-imports.spec.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT added this to the vAnytime milestone Mar 4, 2024
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test labels Mar 4, 2024
Shinigami92
Shinigami92 previously approved these changes Mar 4, 2024
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that looks easy 😲

Co-authored-by: ST-DDT <ST-DDT@gmx.de>
@ST-DDT ST-DDT requested review from Shinigami92 and a team March 4, 2024 14:53
@ST-DDT ST-DDT changed the title test: add test to verify locale code is format lang_country_variant in metadata test: verify locale code is format in metadata Mar 5, 2024
@ST-DDT ST-DDT enabled auto-merge (squash) March 5, 2024 09:55
@ST-DDT ST-DDT merged commit 489bbc2 into faker-js:next Mar 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create test to ensure the locale metadata are correctly filled
3 participants