Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(node): update nvmrc #2735

Merged
merged 3 commits into from
Mar 12, 2024
Merged

infra(node): update nvmrc #2735

merged 3 commits into from
Mar 12, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 11, 2024

Update to iron (Node 20).

Alternatively we could switch to hydrogen (Node 18).

(or should we remove that file?)

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Mar 11, 2024
@ST-DDT ST-DDT added this to the v9.0 milestone Mar 11, 2024
@ST-DDT ST-DDT requested review from a team March 11, 2024 16:09
@ST-DDT ST-DDT self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (554aec4) to head (8ef114f).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2735      +/-   ##
==========================================
- Coverage   99.57%   99.57%   -0.01%     
==========================================
  Files        2859     2859              
  Lines      248602   248602              
  Branches      987      627     -360     
==========================================
- Hits       247556   247545      -11     
- Misses       1017     1028      +11     
  Partials       29       29              

see 2 files with indirect coverage changes

.nvmrc Outdated Show resolved Hide resolved
@xDivisionByZerox
Copy link
Member

Is this file still relevant? We introduced a dev containers environment in #1652, which allows developers to streamline the setup of the projects environment.

@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 12, 2024

Is this file still relevant? We introduced a dev containers environment in #1652, which allows developers to streamline the setup of the projects environment.

Dev containers cause some issues for me when I try to commit due to win vs linux paths.
But are otherwise useful for me if I want to try a script on linux.
I think more people use nvm than devcontainers.

@ST-DDT ST-DDT enabled auto-merge (squash) March 12, 2024 10:42
@ST-DDT
Copy link
Member Author

ST-DDT commented Mar 12, 2024

Lets merge it for now and talk in the teammeeting which dev environment/tooling we want to support.

@ST-DDT ST-DDT merged commit aade09b into next Mar 12, 2024
14 checks passed
@ST-DDT ST-DDT deleted the infra/update/nvmrc branch March 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants