Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(renovate): update config #2736

Merged
merged 7 commits into from
Mar 12, 2024
Merged

infra(renovate): update config #2736

merged 7 commits into from
Mar 12, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Mar 11, 2024

Changes:

See also:

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Mar 11, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Mar 11, 2024
@ST-DDT ST-DDT self-assigned this Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (98e3cec) to head (d382e0b).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2736   +/-   ##
=======================================
  Coverage   99.57%   99.58%           
=======================================
  Files        2859     2859           
  Lines      248602   248602           
  Branches      991      991           
=======================================
+ Hits       247544   247559   +15     
+ Misses       1029     1014   -15     
  Partials       29       29           

see 2 files with indirect coverage changes

@ST-DDT ST-DDT marked this pull request as ready for review March 11, 2024 17:07
@ST-DDT ST-DDT requested a review from a team as a code owner March 11, 2024 17:07
@ST-DDT ST-DDT requested a review from a team March 11, 2024 17:07
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not to sure about the "pin" strategy. Generally it should be more percise as you are literally unable to install incorrect dependencies. I'm not that big of an expert dependency managment, tho.

@ST-DDT ST-DDT requested a review from a team March 11, 2024 22:08
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I feel uncomfortable with the pin because this is a new workflow for me, but lets give it a try, they are devdeps anyway

@ST-DDT ST-DDT merged commit 251b011 into next Mar 12, 2024
18 checks passed
@ST-DDT ST-DDT deleted the infra/renovate/config-update branch March 12, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants