Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v9 #2798

Merged
merged 4 commits into from
Jul 21, 2024
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 8, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) 8.57.0 -> 9.0.0 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner April 8, 2024 00:36
@renovate renovate bot added c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent labels Apr 8, 2024
@renovate renovate bot added this to the vAnytime milestone Apr 8, 2024
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 37f402c
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66993d100ca895000885e433
😎 Deploy Preview https://deploy-preview-2798.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (0059de9) to head (37f402c).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2798    +/-   ##
========================================
  Coverage   99.96%   99.96%            
========================================
  Files        2747     2747            
  Lines      226148   226148            
  Branches      940      588   -352     
========================================
+ Hits       226068   226070     +2     
+ Misses         80       78     -2     

see 1 file with indirect coverage changes

@renovate renovate bot force-pushed the renovate/major-eslint branch 2 times, most recently from c663f98 to 56ad741 Compare April 8, 2024 07:18
@Shinigami92 Shinigami92 self-assigned this Apr 8, 2024
@Shinigami92
Copy link
Member

I would like to explore the new eslint v9 and migrate to FlatConfig, so if nobody else has something against that, I would like to "claim" this PR and address some of my time in the upcoming days for this

@renovate renovate bot force-pushed the renovate/major-eslint branch 5 times, most recently from 92c3bfb to db4f46f Compare April 8, 2024 10:43
@renovate renovate bot changed the title chore(deps): update eslint (major) chore(deps): update dependency eslint to v9 Apr 8, 2024
@Shinigami92 Shinigami92 marked this pull request as draft April 8, 2024 15:05
Copy link
Contributor Author

renovate bot commented Apr 8, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@Shinigami92 Shinigami92 force-pushed the renovate/major-eslint branch 2 times, most recently from e0ed0a4 to 3605045 Compare April 8, 2024 15:29
eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
eslint.config.js Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label Apr 8, 2024
@ST-DDT ST-DDT mentioned this pull request Apr 15, 2024
1 task
@Shinigami92 Shinigami92 force-pushed the renovate/major-eslint branch 3 times, most recently from 7dc2145 to 130504e Compare April 17, 2024 20:35
@Shinigami92 Shinigami92 removed the s: on hold Blocked by something or frozen to avoid conflicts label Apr 17, 2024
@Shinigami92
Copy link
Member

In the past eslint version (9.2 and 9.3) there were backwards compatibility introduced

@Shinigami92 Shinigami92 force-pushed the renovate/major-eslint branch 3 times, most recently from 4a13134 to 068b373 Compare May 26, 2024 19:39
@ST-DDT
Copy link
Member

ST-DDT commented May 26, 2024

What is the status of this PR?

@Shinigami92
Copy link
Member

What is the status of this PR?

#2798 (comment)

@ST-DDT
Copy link
Member

ST-DDT commented Jun 1, 2024

Small progress:

Although it might not be enough yet.

@Shinigami92
Copy link
Member

Small progress:

Although it might not be enough yet.

Please note that I also have a life and can't rush to immediately progress with this PR. Even when I already got notified about that plugin-progress.
Now I got double notified.

@ST-DDT
Copy link
Member

ST-DDT commented Jun 1, 2024

Please note that I also have a life and can't rush to immediately progress with this PR.

That was not my intention.

Now I got double notified.

Sorry, it is a habit from work, where I document any related progress in the ticket itself, so that other readers of the ticket are aware of the status, without being subscribed to the related ticket.

@xDivisionByZerox
Copy link
Member

Small progress:

Although it might not be enough yet.

Please note that I also have a life and can't rush to immediately progress with this PR. Even when I already got notified about that plugin-progress.
Now I got double notified.

There was no "@" in the original message. I was happy to be notified about updates towards the progress of the issue. If you feel overwhelmed by messages in an issue/PR, please use githubs notification system to unsubscribe from notifications from them.

@Shinigami92
Copy link
Member

Small progress:

Although it might not be enough yet.

Please note that I also have a life and can't rush to immediately progress with this PR. Even when I already got notified about that plugin-progress.
Now I got double notified.

There was no "@" in the original message. I was happy to be notified about updates towards the progress of the issue. If you feel overwhelmed by messages in an issue/PR, please use githubs notification system to unsubscribe from notifications from them.

I'm assigned and so also responsible for this issue
I follow the update progress for around a month now
Not even a full day passed since the v3 was release
I'm watched not only the whole Faker organization but also Vite, Vite-ecosystem, prettier-eco, eslint-eco, and multiple of my projects
There are even webhooks I follow

When it is okay to not push other issues and PRs related to my responsibility, it is also okay if we can slow a little bit down with this issue and I can enjoy the last two days of my vacation
I hope this is okay

@Shinigami92
Copy link
Member

Current output with deprecation/deprecation

Oops! Something went wrong! :(

ESLint: 9.4.0

TypeError: context.getAncestors is not a function
Occurred while linting D:\shinigami\OpenSource\faker\.prettierrc.d.ts:1
Rule: "deprecation/deprecation"
    at getParent (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint-plugin-deprecation@3.0.0_eslint@9.4.0_typescript@5.4.5\node_modules\eslint-plugin-deprecation\dist\rules\deprecation.js:86:31)
    at isDeclaration (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint-plugin-deprecation@3.0.0_eslint@9.4.0_typescript@5.4.5\node_modules\eslint-plugin-deprecation\dist\rules\deprecation.js:94:20)
    at identifierRule (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint-plugin-deprecation@3.0.0_eslint@9.4.0_typescript@5.4.5\node_modules\eslint-plugin-deprecation\dist\rules\deprecation.js:60:13)
    at ruleErrorHandler (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\linter.js:1115:48)
    at D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\node-event-generator.js:297:26)    
    at NodeEventGenerator.applySelectors (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\node-event-generator.js:326:22)   
    at NodeEventGenerator.enterNode (D:\shinigami\OpenSource\faker\node_modules\.pnpm\eslint@9.4.0\node_modules\eslint\lib\linter\node-event-generator.js:340:14)        
 ELIFECYCLE  Command failed with exit code 2.
ERROR: "lint" exited with 2.
 ELIFECYCLE  Command failed with exit code 1.

@Shinigami92 Shinigami92 added the s: on hold Blocked by something or frozen to avoid conflicts label Jun 2, 2024
@Shinigami92 Shinigami92 removed the s: on hold Blocked by something or frozen to avoid conflicts label Jul 18, 2024
@Shinigami92 Shinigami92 self-requested a review July 18, 2024 16:08
@Shinigami92 Shinigami92 marked this pull request as ready for review July 18, 2024 16:08
@Shinigami92 Shinigami92 requested review from a team July 18, 2024 16:11
eslint.config.js Show resolved Hide resolved
@ST-DDT ST-DDT merged commit 3806833 into next Jul 21, 2024
23 of 24 checks passed
@ST-DDT ST-DDT deleted the renovate/major-eslint branch July 21, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants