Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add donate links #2806

Merged
merged 9 commits into from
Apr 19, 2024
Merged

Conversation

matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Apr 11, 2024

Add donation links to OC as discussed on Discord, two options

  • In header
Screenshot 2024-04-11 at 20 17 58 Screenshot 2024-04-11 at 20 18 31
  • In footer
Screenshot 2024-04-11 at 20 18 38

(maybe don't need both, see which you prefer and comment on wording)

@matthewmayer matthewmayer requested a review from a team as a code owner April 11, 2024 13:16
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7aae878
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6621e4e5ff4a49000809c27d
😎 Deploy Preview https://deploy-preview-2806.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer self-assigned this Apr 11, 2024
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (100abac) to head (7aae878).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2806      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files        2964     2964              
  Lines      212544   212544              
  Branches      600      946     +346     
==========================================
- Hits       212451   212450       -1     
- Misses         93       94       +1     

see 1 file with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Apr 11, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Apr 11, 2024
@ST-DDT ST-DDT requested review from a team April 11, 2024 17:22
@xDivisionByZerox
Copy link
Member

I'm not a huge fan of the donation link in the navigation. It is not distinguished enough from other "normal" navigation items, IMO. I would be much more in favor of this if the link would not be located in between other items of the main navigation. For example, putting it at the end or to the social media icons (if that is possible).

@matthewmayer
Copy link
Contributor Author

Maybe just start with the footer one only then?

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Apr 14, 2024

That would be an option, but I, as a single team member, don't want to be the entire reason for not putting the link there. Opinions of other team members?

@matthewmayer
Copy link
Contributor Author

Moving it to the right of the version dropdown is also easy. Moving it next to social links is trickier unless there's some clever hack to do that.

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label Apr 14, 2024
@ST-DDT
Copy link
Member

ST-DDT commented Apr 14, 2024

I don't have a strong onion regarding the placement of the button/link.

@Shinigami92
Copy link
Member

I still like to suggest orientating on https://vitejs.dev/.
They have it only at the bottom, but by far more prominent 👀
However I would also prefer to use an open collective icon at the right top next to the other icons.

@xDivisionByZerox
Copy link
Member

I still like to suggest orientating on https://vitejs.dev/.
They have it only at the bottom, but by far more prominent 👀
However I would also prefer to use an open collective icon at the right top next to the other icons.

I like this suggestion. Especially the open collective icon. I didn't know that was possible.

@matthewmayer
Copy link
Contributor Author

Updated to a big button on homepage like vite, and a custom social icon.

Screenshot 2024-04-15 at 16 36 42 Screenshot 2024-04-15 at 16 36 39

ST-DDT
ST-DDT previously approved these changes Apr 15, 2024
@ST-DDT ST-DDT requested a review from a team April 15, 2024 09:49
@xDivisionByZerox
Copy link
Member

@matthewmayer did you copy the css from the vite website? I'd probably write some styles differently, but it works right now.
Thank you for including screenshots of the desktop view. I'm currently on my phone and appreciate them very much.

@matthewmayer
Copy link
Contributor Author

@matthewmayer did you copy the css from the vite website? I'd probably write some styles differently, but it works right now. Thank you for including screenshots of the desktop view. I'm currently on my phone and appreciate them very much.

yes, i copy pasted from the buttons at the top

@matthewmayer
Copy link
Contributor Author

i feel it looks a bit bare with just the floating button

Tried adding a text description too to explain why we are asking for donations

image

Shinigami92
Shinigami92 previously approved these changes Apr 15, 2024
ST-DDT
ST-DDT previously approved these changes Apr 17, 2024
docs/.vitepress/config.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label Apr 18, 2024
@matthewmayer matthewmayer dismissed stale reviews from Shinigami92 and ST-DDT via c498cff April 19, 2024 03:23
@ST-DDT ST-DDT requested review from a team and xDivisionByZerox April 19, 2024 05:33
@Shinigami92 Shinigami92 merged commit 48ab524 into faker-js:next Apr 19, 2024
20 checks passed
matthewmayer added a commit to matthewmayer/faker that referenced this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants