Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor migration guide updates #2811

Merged
merged 23 commits into from
Apr 22, 2024

Conversation

matthewmayer
Copy link
Contributor

  • standardize title case for headings
  • clearer headings
  • grammar simplification
  • present tense
  • add link to enforce-unique
  • enforce-unique does now include exclude

- standardize title case for headings
- clearer headings
- grammar simplification
- present tense
- add link to enforce-unique
- enforce-unique does now include exclude
@matthewmayer matthewmayer requested a review from a team as a code owner April 13, 2024 14:26
Copy link

netlify bot commented Apr 13, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ecb2ca1
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6626cb7696894f00083410ad
😎 Deploy Preview https://deploy-preview-2811.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (b754dc6) to head (c428144).
Report is 1 commits behind head on next.

❗ Current head c428144 differs from pull request most recent head ecb2ca1. Consider uploading reports for the commit ecb2ca1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2811   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files        2973     2973           
  Lines      212613   212613           
  Branches      943      946    +3     
=======================================
+ Hits       212510   212525   +15     
+ Misses        103       88   -15     

see 2 files with indirect coverage changes

@matthewmayer matthewmayer self-assigned this Apr 13, 2024
@matthewmayer matthewmayer added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Apr 13, 2024
ST-DDT
ST-DDT previously approved these changes Apr 13, 2024
docs/guide/upgrading.md Outdated Show resolved Hide resolved
ST-DDT
ST-DDT previously approved these changes Apr 14, 2024
@ST-DDT ST-DDT requested review from a team April 14, 2024 06:41
@ST-DDT ST-DDT added this to the v9.0 milestone Apr 14, 2024
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
matthewmayer and others added 6 commits April 15, 2024 08:50
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
Copy link
Member

@Shinigami92 Shinigami92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check further from line 140+ later, but got to catch a meeting now

docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
docs/guide/upgrading.md Outdated Show resolved Hide resolved
matthewmayer and others added 4 commits April 15, 2024 16:10
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Co-authored-by: Shinigami <chrissi92@hotmail.de>
@matthewmayer
Copy link
Contributor Author

i have updated the info about enforce-unique taking into account everyone's comments.

@ST-DDT ST-DDT enabled auto-merge (squash) April 22, 2024 20:41
@ST-DDT ST-DDT merged commit 855e6a2 into faker-js:next Apr 22, 2024
18 checks passed
@ST-DDT
Copy link
Member

ST-DDT commented Apr 23, 2024

@RD-CL Thanks for bringing this to our attention.
Please contact us at ert@fakerjs.dev with details so that we can look into that.
GitHub issues is the wrong place to bring this up, so please refrain from further comments here.

@faker-js faker-js deleted a comment Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants