Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): activate data normalization for color #2837

Merged
merged 3 commits into from
Apr 21, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265

Normalize the entries in the color module definitions in all locales.

I choose this module because only one file per locale. This should make reviews more trivial.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: color Something is referring to the color module labels Apr 19, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner April 19, 2024 17:44
@xDivisionByZerox xDivisionByZerox self-assigned this Apr 19, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team April 19, 2024 17:44
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Apr 19, 2024
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 416e89e
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/662560d3ce8d890008e43a5c
😎 Deploy Preview https://deploy-preview-2837.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (81d0718) to head (416e89e).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2837      +/-   ##
==========================================
- Coverage   99.96%   99.95%   -0.01%     
==========================================
  Files        2973     2973              
  Lines      212613   212613              
  Branches      948      602     -346     
==========================================
- Hits       212528   212526       -2     
- Misses         85       87       +2     
Files Coverage Δ
src/locales/ar/color/human.ts 100.00% <100.00%> (ø)
src/locales/az/color/human.ts 100.00% <100.00%> (ø)
src/locales/base/color/space.ts 100.00% <100.00%> (ø)
src/locales/dv/color/human.ts 100.00% <100.00%> (ø)
src/locales/el/color/human.ts 100.00% <100.00%> (ø)
src/locales/en/color/human.ts 100.00% <100.00%> (ø)
src/locales/es/color/human.ts 100.00% <100.00%> (ø)
src/locales/es_MX/color/human.ts 100.00% <100.00%> (ø)
src/locales/fa/color/human.ts 100.00% <100.00%> (ø)
src/locales/fr/color/human.ts 100.00% <100.00%> (ø)
... and 16 more

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from matthewmayer and a team April 19, 2024 22:32
@ST-DDT ST-DDT enabled auto-merge (squash) April 21, 2024 18:54
@ST-DDT ST-DDT merged commit b754dc6 into next Apr 21, 2024
20 checks passed
@ST-DDT ST-DDT deleted the refactor/locale/activate-data-normalization-for-color branch April 21, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: color Something is referring to the color module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants