Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(locale): normalize hacker data #2866

Merged
merged 3 commits into from
May 1, 2024

Conversation

xDivisionByZerox
Copy link
Member

Description

Follow-on to #2265.

Normalize the entries in the hacker module definitions in all locales.

I choose this module as locale data are still limited. Additionally, no data set exceedes the 1k entry limit, so all locale file changes are based on entry sorting.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: hacker Something is referring to the hacker module labels Apr 29, 2024
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Apr 29, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team April 29, 2024 22:26
@xDivisionByZerox xDivisionByZerox self-assigned this Apr 29, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner April 29, 2024 22:26
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 82cbd34
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/663221226f2a640008d95d56
😎 Deploy Preview https://deploy-preview-2866.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (d23cd68) to head (321e584).

❗ Current head 321e584 differs from pull request most recent head 82cbd34. Consider uploading reports for the commit 82cbd34 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2866      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files        2975     2975              
  Lines      214451   214451              
  Branches      945      597     -348     
==========================================
- Hits       214349   214347       -2     
- Misses        102      104       +2     
Files Coverage Δ
src/locales/el/hacker/abbreviation.ts 100.00% <100.00%> (ø)
src/locales/el/hacker/adjective.ts 100.00% <100.00%> (ø)
src/locales/el/hacker/noun.ts 100.00% <100.00%> (ø)
src/locales/el/hacker/verb.ts 100.00% <100.00%> (ø)
src/locales/en/hacker/adjective.ts 100.00% <100.00%> (ø)
src/locales/en/hacker/ingverb.ts 100.00% <100.00%> (ø)
src/locales/en/hacker/noun.ts 100.00% <100.00%> (ø)
src/locales/en/hacker/phrase.ts 100.00% <100.00%> (ø)
src/locales/en/hacker/verb.ts 100.00% <100.00%> (ø)
src/locales/eo/hacker/adjective.ts 100.00% <100.00%> (ø)
... and 15 more

... and 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team April 30, 2024 06:04
src/locales/el/hacker/noun.ts Show resolved Hide resolved
@ST-DDT ST-DDT enabled auto-merge (squash) May 1, 2024 11:01
@ST-DDT ST-DDT merged commit 2d5fbe5 into next May 1, 2024
18 checks passed
@ST-DDT ST-DDT deleted the refactor/locale/normalize-hacker-data branch May 1, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: hacker Something is referring to the hacker module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants