Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove unused dependency conventional-changelog-cli #2879

Merged
merged 2 commits into from
May 6, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 6, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
conventional-changelog-cli (source) 4.1.0 -> N/A - - - -

Release Notes

Removed


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 6, 2024 00:22
@renovate renovate bot added c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent labels May 6, 2024
@renovate renovate bot added this to the vAnytime milestone May 6, 2024
Copy link

netlify bot commented May 6, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit cf5b29b
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/663891992a335f0008d6e25d
😎 Deploy Preview https://deploy-preview-2879.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (0965988) to head (cf5b29b).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2879   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2975     2975           
  Lines      214451   214451           
  Branches      951      950    -1     
=======================================
+ Hits       214366   214370    +4     
+ Misses         85       81    -4     

see 1 file with indirect coverage changes

import-brain
import-brain previously approved these changes May 6, 2024
@xDivisionByZerox
Copy link
Member

⚠ BREAKING CHANGES

[...]

  • Now all packages, except gulp-conventional-changelog, are ESM-only.

@Shinigami92 an other one for the list 👍

@xDivisionByZerox
Copy link
Member

Do we still use this package? The only check we are doing for conventional commits is in the PR title, which is checked by a github workflow action (not from package.json). I might be wrong tho.

@renovate renovate bot force-pushed the renovate/major-devdependencies branch 3 times, most recently from 7a1d354 to 4b5a489 Compare May 6, 2024 07:00
@ST-DDT
Copy link
Member

ST-DDT commented May 6, 2024

Do we still use this package? The only check we are doing for conventional commits is in the PR title, which is checked by a github workflow action (not from package.json). I might be wrong tho.

The dependency was added here:

78dc2ca

And never referenced in any commit after that (except dep updates).

So it should we safe to remove, we should check though whether it is implicitly used by standard-version/our release.

@Shinigami92
Copy link
Member

So it should we safe to remove, we should check though whether it is implicitly used by standard-version/our release.

standard-version has its own copy of even more outdated sub-dependency

image

@ST-DDT
Copy link
Member

ST-DDT commented May 6, 2024

I will update this PR to remove the dependency instead.

@ST-DDT ST-DDT self-assigned this May 6, 2024
Copy link
Contributor Author

renovate bot commented May 6, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@ST-DDT ST-DDT changed the title chore(deps): update dependency conventional-changelog-cli to v5 chore(deps): remove unused dependency conventional-changelog-cli May 6, 2024
@ST-DDT ST-DDT merged commit 043f68b into next May 6, 2024
24 checks passed
@ST-DDT ST-DDT deleted the renovate/major-devdependencies branch May 6, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants