Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(vitest): no-alias-methods #2899

Merged
merged 3 commits into from
May 18, 2024
Merged

infra(vitest): no-alias-methods #2899

merged 3 commits into from
May 18, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 13, 2024

Enables the vitest/no-alias-methods lint rule.

  • toThrow: 96
  • toThrowError: 8

Except very slow reaction times from my side this week.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: test c: infra Changes to our infrastructure or project setup labels May 13, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 13, 2024
@ST-DDT ST-DDT requested review from a team May 13, 2024 11:38
@ST-DDT ST-DDT self-assigned this May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit f3347f0
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6648f00b1e832500081ae647
😎 Deploy Preview https://deploy-preview-2899.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (9226945) to head (f3347f0).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2899   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files        2977     2977           
  Lines      215422   215422           
  Branches      598      600    +2     
=======================================
+ Hits       215333   215335    +2     
+ Misses         89       87    -2     

see 1 file with indirect coverage changes

@ST-DDT ST-DDT requested a review from a team May 13, 2024 19:41
@ST-DDT ST-DDT enabled auto-merge (squash) May 18, 2024 18:14
@ST-DDT ST-DDT merged commit 7dc8a18 into next May 18, 2024
20 checks passed
@ST-DDT ST-DDT deleted the infra/vitest/no-alias-methods branch May 18, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup c: test p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants