Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(typescript-eslint): no-confusing-void-expression #2909

Merged
merged 5 commits into from
May 25, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 18, 2024

Configures the @typescript-eslint/no-confusing-void-expression rule.

IMO void arrow functions are easier to read than them being wrapped in brackets.


This is an attempt at removing some TODOs from the source.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels May 18, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 18, 2024
@ST-DDT ST-DDT requested review from a team May 18, 2024 10:30
@ST-DDT ST-DDT self-assigned this May 18, 2024
Copy link

netlify bot commented May 18, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 866a8b5
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66523ff966e8140008f40330
😎 Deploy Preview https://deploy-preview-2909.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (558b959) to head (866a8b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2909      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files        2977     2977              
  Lines      215421   215421              
  Branches      950      598     -352     
==========================================
- Hits       215330   215328       -2     
- Misses         91       93       +2     

see 2 files with indirect coverage changes

test/modules/helpers.spec.ts Show resolved Hide resolved
test/modules/helpers.spec.ts Outdated Show resolved Hide resolved
@ST-DDT ST-DDT requested review from xDivisionByZerox and a team May 19, 2024 12:49
@ST-DDT ST-DDT enabled auto-merge (squash) May 25, 2024 19:46
@ST-DDT ST-DDT merged commit a60f097 into next May 25, 2024
20 checks passed
@ST-DDT ST-DDT deleted the infra/typescript-eslint/no-confusing-void-expression branch May 25, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants