Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra(ci): enable node 22 #2918

Merged
merged 3 commits into from
May 27, 2024
Merged

infra(ci): enable node 22 #2918

merged 3 commits into from
May 27, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented May 20, 2024

Enable node 22 for CI

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels May 20, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 20, 2024
@ST-DDT ST-DDT self-assigned this May 20, 2024
@ST-DDT ST-DDT requested a review from a team as a code owner May 20, 2024 16:16
Copy link

netlify bot commented May 20, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit f3732d2
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/6654456478d2ef00082d2afe
😎 Deploy Preview https://deploy-preview-2918.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (353e85c) to head (f3732d2).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2918   +/-   ##
=======================================
  Coverage   99.95%   99.96%           
=======================================
  Files        2977     2977           
  Lines      215421   215421           
  Branches      951      950    -1     
=======================================
+ Hits       215333   215343   +10     
+ Misses         88       78   -10     

see 1 file with indirect coverage changes

@xDivisionByZerox xDivisionByZerox requested review from a team May 21, 2024 18:57
@ST-DDT
Copy link
Member Author

ST-DDT commented May 23, 2024

Should we keep the node-20/22 in the name if the special actions such as Lint/TS-Check?
If we remove them, we don't have to change the required CI steps every time we change that.

@ST-DDT ST-DDT added the s: needs decision Needs team/maintainer decision label May 23, 2024
@Shinigami92
Copy link
Member

Should we keep the node-20/22 in the name if the special actions such as Lint/TS-Check? If we remove them, we don't have to change the required CI steps every time we change that.

IMO we should keep them, so we have these info in the checks section at bottom of a PR

@ST-DDT ST-DDT removed the s: needs decision Needs team/maintainer decision label May 27, 2024
@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented May 27, 2024

I've updated the next branch protection to require "Lint: node-22, ubuntu-latest" and "TS-Check: node-22, ubuntu-latest" instead of "$1: node-20, $2" and added the "Build & Unit Test: node-22, " actions. Other branches need to merge next first.

@xDivisionByZerox xDivisionByZerox merged commit 29c5a18 into next May 27, 2024
24 checks passed
@xDivisionByZerox xDivisionByZerox deleted the infra/node-22 branch May 27, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants