Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(locale): extend Hebrew (he) for company #2921

Merged
merged 5 commits into from
May 29, 2024

Conversation

ShaharIlany
Copy link
Contributor

No description provided.

@ShaharIlany ShaharIlany requested a review from a team as a code owner May 24, 2024 20:14
Copy link

netlify bot commented May 24, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 33326e2
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/665594741cc7d900083f715f
😎 Deploy Preview https://deploy-preview-2921.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewmayer matthewmayer changed the title feat(locale): extend Hebrew (he) feat(locale): extend Hebrew (he) for company May 25, 2024
Copy link

codecov bot commented May 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (a756350) to head (33326e2).

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #2921    +/-   ##
========================================
  Coverage   99.95%   99.95%            
========================================
  Files        2977     2986     +9     
  Lines      215421   215926   +505     
  Branches      946      948     +2     
========================================
+ Hits       215319   215835   +516     
+ Misses        102       91    -11     
Files Coverage Δ
src/locales/he/company/adjective.ts 100.00% <100.00%> (ø)
src/locales/he/company/buzz_adjective.ts 100.00% <100.00%> (ø)
src/locales/he/company/buzz_noun.ts 100.00% <100.00%> (ø)
src/locales/he/company/buzz_verb.ts 100.00% <100.00%> (ø)
src/locales/he/company/descriptor.ts 100.00% <100.00%> (ø)
src/locales/he/company/index.ts 100.00% <100.00%> (ø)
src/locales/he/company/name_pattern.ts 100.00% <100.00%> (ø)
src/locales/he/company/noun.ts 100.00% <100.00%> (ø)
src/locales/he/company/suffix.ts 100.00% <100.00%> (ø)
src/locales/he/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes May 27, 2024
@ST-DDT ST-DDT requested review from a team May 27, 2024 15:08
@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: company Something is referring to the company module labels May 27, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone May 27, 2024
Shinigami92
Shinigami92 previously approved these changes May 27, 2024
@ShaharIlany ShaharIlany dismissed stale reviews from Shinigami92 and ST-DDT via 6bc06c7 May 28, 2024 08:22
@ST-DDT ST-DDT requested a review from a team May 28, 2024 19:12
@xDivisionByZerox xDivisionByZerox merged commit 29df384 into faker-js:next May 29, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: locale Permutes locale definitions m: company Something is referring to the company module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants