refactor(locale): rename company affix files

[ST-DDT]

Fixes #1574

• Rename company.suffix definition to company.legal_entity_type #1574

This PR renames the company prefix and suffix files to category/legal_entity_type respectively.

[netlify]

✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	494f443
🔍 Latest deploy log	https://app.netlify.com/sites/fakerjs/deploys/667bc5af4be3e600086c20a5
😎 Deploy Preview	https://deploy-preview-2975.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (8134b33) to head (1ddc1e2).

❗ Current head 1ddc1e2 differs from pull request most recent head 494f443

Please upload reports for the commit 494f443 to get more accurate results.

Additional details and impacted files

@@           Coverage Diff            @@
##             next    #2975    +/-   ##
========================================
  Coverage   99.95%   99.96%            
========================================
  Files        2989     2984     -5     
  Lines      216081   216057    -24     
  Branches      596      949   +353     
========================================
- Hits       215980   215975     -5     
+ Misses        101       82    -19     

Files	Coverage Δ
src/locales/af_ZA/company/index.ts	100.00% <100.00%> (ø)
src/locales/af_ZA/company/legal_entity_type.ts	100.00% <ø> (ø)
src/locales/az/company/index.ts	100.00% <100.00%> (ø)
src/locales/az/company/legal_entity_type.ts	100.00% <ø> (ø)
src/locales/az/company/name_pattern.ts	100.00% <100.00%> (ø)
src/locales/cs_CZ/company/index.ts	100.00% <100.00%> (ø)
src/locales/cs_CZ/company/legal_entity_type.ts	100.00% <ø> (ø)
src/locales/cs_CZ/company/name_pattern.ts	100.00% <100.00%> (ø)
src/locales/da/company/index.ts	100.00% <100.00%> (ø)
src/locales/da/company/legal_entity_type.ts	100.00% <ø> (ø)
... and 100 more

... and 2 files with indirect coverage changes

[ST-DDT]

I was unable to identify which part is the category or legal_entity_type in lv and ru.
Maybe they have the legal_entity_type sometimes as prefix and sometimes as suffix?

• https://github.com/faker-js/faker/tree/next/src/locales/lv/company
• https://github.com/faker-js/faker/tree/next/src/locales/ru/company

@serembon @salixzs: Are you able to clarify this?

I contacted you as creators of these commits:

• cf64d76
• 81171c9

[serembon]

@ST-DDT hello! prefix can only be legal_entity_type

[ST-DDT]

@ST-DDT hello! prefix can only be legal_entity_type

@serembon Thanks for your fast response. What would you call the suffix in that case?

[serembon]

This is part of the company name. It is necessary to save this name_patterns for generating a name from parts

{{company.suffix}}{{company.suffix}}'
{{company.suffix}}{{company.suffix}}{{company.suffix}}

If you use only one part, the company name will not be similar to the real one.

[ST-DDT]

So the suffix is actually the suffix in this case?

[serembon]

So the suffix is actually the suffix in this case?

Right

[xDivisionByZerox]

I just noticed that we missed the update of CompanyDefinition in this PR.
@ST-DDT Was this intended, since "suffix" was never part of it in the first place?

[ST-DDT]

@ST-DDT Was this intended, since "suffix" was never part of it in the first place?

It was never part of it in the first place (It is only usd by fake patterns).