chore: remove unused function mergeArrays

[ST-DDT]

The mergeArrays function was needed as a workaround to create the generic files for first and last names.
Those have become obsolete now and thus we don't need this internal utility function anymore.

Ref:

• refactor(locale): group name entries by gender #2938

[netlify]

✅ Deploy Preview for fakerjs ready!

Name	Link
🔨 Latest commit	59b894a
🔍 Latest deploy log	https://app.netlify.com/sites/fakerjs/deploys/66828f0c38d4e800084379e9
😎 Deploy Preview	https://deploy-preview-2989.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (0679d99) to head (59b894a).

Additional details and impacted files

@@           Coverage Diff           @@
##             next    #2989   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2748     2747    -1     
  Lines      239091   239079   -12     
  Branches      946      947    +1     
=======================================
+ Hits       239003   239009    +6     
+ Misses         88       70   -18     

see 3 files with indirect coverage changes

[xDivisionByZerox]

Not sure wether we might need it again in the future. I'll still approve, since we have the git history.

[xDivisionByZerox]

For future refactor: Is there a TS config option to notify about dead code when resolving the main entry point? Should we look into that?

[Shinigami92]

For future refactor: Is there a TS config option to notify about dead code when resolving the main entry point? Should we look into that?

I don't think there is.
It would need to traverse every .ts (tsx, dts, mts and their js and even Vue equivalents, and those I forgot)

e.g. a project could contain 1000 src files and there is a .vue file that imports a .ts file. You would need the whole dependency graph.

And even then, your project could have multiple entry points.
Feels like an impossible task 😅

Maybe tsup, esbuild or eslint could tackle such tasks. But bundlers won't affect the src code. And the scope for eslint is also questionable.

[ST-DDT]

Code coverage ftw.

[Shinigami92]

Code coverage ftw.

#yes

however, when you have covered code with tests, it does not tell you if it is already used by the source 😉