Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rimraf to v6 #3016

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 15, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rimraf 5.0.9 -> 6.0.1 age adoption passing confidence

Release Notes

isaacs/rimraf (rimraf)

v6.0.1

Compare Source

v6.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner July 15, 2024 00:48
@renovate renovate bot added c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent labels Jul 15, 2024
@renovate renovate bot added this to the vAnytime milestone Jul 15, 2024
Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit f824d95
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/669d6f042df4af00083f182a
😎 Deploy Preview https://deploy-preview-3016.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (907996c) to head (f824d95).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3016      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2747     2747              
  Lines      226148   226148              
  Branches      946      947       +1     
==========================================
- Hits       226093   226081      -12     
- Misses         55       67      +12     

see 1 file with indirect coverage changes

@renovate renovate bot force-pushed the renovate/major-devdependencies branch 5 times, most recently from 8aa5bd5 to b1919b8 Compare July 16, 2024 18:18
ST-DDT
ST-DDT previously approved these changes Jul 16, 2024
@ST-DDT ST-DDT requested review from a team July 16, 2024 19:44
@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Jul 16, 2024

From the changelog:

Drop support for nodes before v20

This basically raises the developer setup to be at Node 20.
Node.js 18 is stillsupported until 30 Apr 2025..


Nothing to critical, but should propably mentioned in the new contribution guidelines.

import-brain
import-brain previously approved these changes Jul 17, 2024
@renovate renovate bot dismissed stale reviews from import-brain, xDivisionByZerox, and ST-DDT via 60bd330 July 17, 2024 10:15
@renovate renovate bot force-pushed the renovate/major-devdependencies branch from b1919b8 to 60bd330 Compare July 17, 2024 10:15
import-brain
import-brain previously approved these changes Jul 17, 2024
@renovate renovate bot force-pushed the renovate/major-devdependencies branch from 60bd330 to 6b96a65 Compare July 17, 2024 11:02
@ST-DDT
Copy link
Member

ST-DDT commented Jul 17, 2024

@ST-DDT
Copy link
Member

ST-DDT commented Jul 17, 2024

FYI: Rimraf v6.0.1 seems to work on node v18.
But I'm not sure about upgrading.

@renovate renovate bot force-pushed the renovate/major-devdependencies branch from 637bc0f to f824d95 Compare July 21, 2024 20:26
@ST-DDT ST-DDT added the s: on hold Blocked by something or frozen to avoid conflicts label Jul 21, 2024
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no problem with bumping the minimum required node version for the dev setup. That's why I'm already approving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: dependencies Pull requests that adds/updates a dependency p: 1-normal Nothing urgent s: on hold Blocked by something or frozen to avoid conflicts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants