Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: polish migration guide #3027

Merged
merged 16 commits into from
Aug 15, 2024
Merged

docs: polish migration guide #3027

merged 16 commits into from
Aug 15, 2024

Conversation

xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox commented Jul 24, 2024 •
edited by ST-DDT
Loading

@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Jul 24, 2024
@xDivisionByZerox xDivisionByZerox added this to the v9.0 milestone Jul 24, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team July 24, 2024 18:36
@xDivisionByZerox xDivisionByZerox self-assigned this Jul 24, 2024
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner July 24, 2024 18:36
@xDivisionByZerox xDivisionByZerox changed the title docs: remove tsup section from migration guide docs: polish migration guide Jul 24, 2024
@netlify Netlify
Copy link

netlify bot commented Jul 24, 2024 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 89a000d
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66be298b89e0a80008d543ac
😎 Deploy Preview https://deploy-preview-3027.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Jul 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (ff808d5) to head (89a000d).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3027   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2772     2772           
  Lines      226173   226173           
  Branches      941      942    +1     
=======================================
+ Hits       226105   226110    +5     
+ Misses         68       63    -5

see 2 files with indirect coverage changes

ST-DDT
ST-DDT reviewed Jul 24, 2024
View reviewed changes
docs/guide/upgrading.md Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 enabled auto-merge (squash) August 15, 2024 16:15
@Shinigami92 Shinigami92 merged commit 466c8ba into next Aug 15, 2024
21 checks passed
@Shinigami92 Shinigami92 deleted the docs/polish-migration-guide branch August 15, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewmayer matthewmayer matthewmayer left review comments

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@xDivisionByZerox xDivisionByZerox

Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Milestone
v9.0
Development

Successfully merging this pull request may close these issues.

v9 migration guide polish
5 participants
@xDivisionByZerox @matthewmayer @ST-DDT @Shinigami92 @import-brain