Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: improve CI preflight warning message #3039

Merged
merged 3 commits into from
Aug 9, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Aug 5, 2024

Fixes #1840

Suggestions for other/better messages are welcome.

Preview

grafik

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: infra Changes to our infrastructure or project setup labels Aug 5, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Aug 5, 2024
@ST-DDT ST-DDT requested review from a team August 5, 2024 21:18
@ST-DDT ST-DDT self-assigned this Aug 5, 2024
Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 4923373
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66b62c715bbbcd000818eb94
😎 Deploy Preview https://deploy-preview-3039.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (354ff4a) to head (4923373).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3039      +/-   ##
==========================================
+ Coverage   99.95%   99.97%   +0.01%     
==========================================
  Files        2772     2772              
  Lines      226173   226173              
  Branches      934      943       +9     
==========================================
+ Hits       226071   226108      +37     
+ Misses        102       65      -37     

see 2 files with indirect coverage changes

@Shinigami92
Copy link
Member

The capital CI in PR title looks weird to me, maybe align on something from the history: https://github.com/faker-js/faker/commits/next/.github/workflows/commentCodeGeneration.ts

@ST-DDT ST-DDT changed the title infra(CI): improve preflight warning message infra: improve CI preflight warning message Aug 7, 2024
@ST-DDT ST-DDT merged commit 7fa2f99 into next Aug 9, 2024
23 checks passed
@ST-DDT ST-DDT deleted the infra/ci/preflight-warning-message branch August 9, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github-actions bot also triggers when build step failed
4 participants