Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consistent linking to sponsored services #3120

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 16, 2024

IMO we should link to both hosted services. Also changed the wording to make it more fluent (at least IMO).

@ST-DDT ST-DDT added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Sep 16, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Sep 16, 2024
@ST-DDT ST-DDT requested review from a team September 16, 2024 13:30
@ST-DDT ST-DDT self-assigned this Sep 16, 2024
Copy link

netlify bot commented Sep 16, 2024

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 06d9713
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/66e87a20361bf90008e6912e
😎 Deploy Preview https://deploy-preview-3120.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (d8737b5) to head (06d9713).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3120      +/-   ##
==========================================
- Coverage   99.96%   99.96%   -0.01%     
==========================================
  Files        2776     2776              
  Lines      226262   226262              
  Branches      589      939     +350     
==========================================
- Hits       226183   226182       -1     
- Misses         79       80       +1     

see 1 file with indirect coverage changes

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@ST-DDT ST-DDT enabled auto-merge (squash) September 16, 2024 18:33
@ST-DDT ST-DDT merged commit af01db9 into next Sep 16, 2024
21 checks passed
@ST-DDT ST-DDT deleted the docs/README/consistent-links branch September 16, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants